Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43653?usp=email )
Change subject: Add support for polling multiple eIMs ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43653/comment/21491ed7_4a07c505?... : PS2, Line 151: static struct ipa_context *ctx = NULL; I would suggest to move this to the top of the module and to add a comment.
(I don't know if this is a coding style thing, but I always prefer to declare variables at the beginning of a module or function, it is then much easier to see what states a module or function has.)
-
dexter