Attention is currently required from: jolly.

Patch set 2:Code-Review +1

View Change

3 comments:

• File src/ipa/libipa/es10b_get_eim_cfg_data.c:

  • Patch Set #2, Line 297:

    maybe set *eim_cfg_data_item = NULL; for good measure?

  • Patch Set #2, Line 309: /* In case no eim_id is specified, just pick the item from the list that is specified by index */

    Maybe rephrase the comment a bit?

    In case no eim_id is specified, pick the eim_cfg_data_item by its index and exit.

  • Patch Set #2, Line 317:

    Maybe add a comment?

    
    Otherwise find the eim_cfg_data_item by the specified eim_id and exit.

To view, visit change 43652. To unsubscribe, or for help writing mail filters, visit settings.