Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31117
)
Change subject: pcuif_proto: add indication to communicate E1 parameters
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File include/osmocom/bsc/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31117/comment/53094f02_4dd1c4a6
PS1, Line 263: uint8_t pdch_trx_nr;
I don't see the point of having "pdch" here. Of course it is a pdch. We
don't write "pdch" in other trx_nr/ts_nr fields.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31117
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3a0f6ae6b98694458230d7c0ac2c89b332cfbc92
Gerrit-Change-Number: 31117
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 12:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment