Attention is currently required from: laforge, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31112
)
Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/osmo-bsc/bts_trx.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/3fa17916_17ef8bb9
PS2, Line 335:
so you are checking in default case a specific pchan inside a switch with pchan cases...
switch (ts->pchan_from_config) {
case GSM_PCHAN_PDCH:
if (is_ericsson_bts(trx->bts)) {
result = false;
}
break;
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31112
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27
Gerrit-Change-Number: 31112
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 12:10:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment