Attention is currently required from: laforge, pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30876
)
Change subject: pcu_sock: rework check logic for ts
......................................................................
Patch Set 8:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/e1997c45_64e2b9c7
PS2, Line 96: static bool ts_is_pdch(const struct gsm_bts_trx_ts *ts)
Done
The PDCH check is now implemented so that
it checks if the TS can be used as PDCH in that very moment. As far as I understand that
is the correct way. the PCU will then send the gsm_pcu_if_act_req, which is not really an
activation request. As far as we are concerned its a confirmation that the PDCH is
activated at the PCU. The naming scheme is a bit distracting. In osmo-bts the
gsm_pcu_if_act_req message means the activation of SAPIs and so on, which is the last step
in the whole activation process. We don't have that here. We just do a channel
activation and the timeslot fsm will trigger the sending of the gsm_pcu_if_info_ind ind
thats it. The PCU will respond with gsm_pcu_if_act_req as a confirmation (which we may
ignore?)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30876
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a
Gerrit-Change-Number: 30876
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 12:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment