Attention is currently required from: hampushellsberg, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43984?usp=email ) Change subject: esim.saip: derive nb_rec from efFileSize when the descriptor omits it ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS4: I think its clear to me now, let's merge the patch as it is. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43984/comment/ac50893c_1257358d?usp=ema... : PS3, Line 369: if self.rec_len and not fd_dec['num_of_rec']:
The difference is a file that comes from a template: File. […] Thanks for clarifying. I didn't know that self.nb_rec might have a value. I thought that we would always have a freshly initialized class.
ALso if I view it from another angle: This method is called from_fileDescriptor, so why not take directly from fd_dec (which is derived from the fileDescriptor parameter)? (You might consider to add a comment with a follow-up patch to the section where we initialize those properties.) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I191b234446c278a5252a903d170c3336d9e0c1ba Gerrit-Change-Number: 43984 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 03 Nov 2026 13:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>