Attention is currently required from: hampushellsberg, laforge.
Patch set 4:Code-Review +2
2 comments:
Patchset:
I think its clear to me now, let's merge the patch as it is.
File pySim/esim/saip/__init__.py:
Patch Set #3, Line 369: if self.rec_len and not fd_dec['num_of_rec']:
The difference is a file that comes from a template: File. […]
Thanks for clarifying. I didn't know that self.nb_rec might have a value. I thought that we would always have a freshly initialized class.
ALso if I view it from another angle: This method is called from_fileDescriptor, so why not take directly from fd_dec (which is derived from the fileDescriptor parameter)?
(You might consider to add a comment with a follow-up patch to the section where we initialize those properties.)
To view, visit change 43984. To unsubscribe, or for help writing mail filters, visit settings.