Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32764 )
Change subject: devices: add freq/gain override for uhd ......................................................................
Patch Set 5:
(5 comments)
Patchset:
PS5: commit description should be updated with more context regarding the use case.
File Transceiver52M/device/uhd/UHDDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/02c068bc_a3f4bf64 PS5, Line 298: if (cfg->overrides.ul_freq_override) I'm lost here. You are skipping setting the gain below if the ul frequency is overriden? why?
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/beacc409_6995352a PS5, Line 344: return 0.0f; I would expect the power atenuattion to be set to the overwriten value instead of returning?
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/6e73ed99_848f945b PS5, Line 635: if (cfg->overrides.dl_freq_override) { why are you doing it here instead of the place where the freq/gain is supposed to be updated?
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/aa8d7095_cb99a14b PS5, Line 1013: if (cfg->overrides.dl_freq_override || cfg->overrides.ul_freq_override) I would expected the overwritten frequency to be set here?