Attention is currently required from: Hoernchen.
5 comments:
Patchset:
commit description should be updated with more context regarding the use case.
File Transceiver52M/device/uhd/UHDDevice.cpp:
Patch Set #5, Line 298: if (cfg->overrides.ul_freq_override)
I'm lost here. You are skipping setting the gain below if the ul frequency is overriden? why?
Patch Set #5, Line 344: return 0.0f;
I would expect the power atenuattion to be set to the overwriten value instead of returning?
Patch Set #5, Line 635: if (cfg->overrides.dl_freq_override) {
why are you doing it here instead of the place where the freq/gain is supposed to be updated?
Patch Set #5, Line 1013: if (cfg->overrides.dl_freq_override || cfg->overrides.ul_freq_override)
I would expected the overwritten frequency to be set here?
To view, visit change 32764. To unsubscribe, or for help writing mail filters, visit settings.