Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ...................................................................... Patch Set 16: (6 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/721e1f69_6f048... : PS15, Line 2194: as_gmm_auth
Why do you activate the authentication handler so early? According to the test scenario, it's expect […] as_gmm_auth() triggers before lu_isd(). IMHO: the authentication is off-topic for this test case. The testcase don't care if auth is done or not, otherwise the testcase will also fail when the authentication has a problem. I moved it anyway, but still don't think the TC should care.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d190dcaf_f194a... : PS15, Line 2199: // f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[0]);
This can be removed? Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d760280c_26e28... : PS15, Line 2210: as_gmm_gsup_lu_isd
IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you ju […] Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/b56d27e2_4deb0... : PS15, Line 2223: FIXME
Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction. Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/36b35474_329a4... : PS15, Line 2228: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
Why do you need to shutdown like this here? Removed it. Not needed
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/549d94c9_c9719... : PS15, Line 2237: Identity Request IMSI (retrans)
Likewise, the test does reply to the 2nd Identity Request. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc Gerrit-Change-Number: 39256 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Sep 2026 10:48:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de>