Attention is currently required from: fixeria, laforge, pespin.

View Change

6 comments:

• File sgsn/SGSN_Tests.ttcn:

  • Patch Set #15, Line 2194: as_gmm_auth

    Why do you activate the authentication handler so early? According to the test scenario, it's expect […]

    as_gmm_auth() triggers before lu_isd().
    IMHO: the authentication is off-topic for this test case.
    The testcase don't care if auth is done or not, otherwise the testcase will also fail when the authentication has a problem.
    I moved it anyway, but still don't think the TC should care.

  • Patch Set #15, Line 2199: // f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[0]);

    This can be removed?

    Done

  • Patch Set #15, Line 2210: as_gmm_gsup_lu_isd

    IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you ju […]

    Done

  • Patch Set #15, Line 2223: FIXME

    Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction.

    Done

  • Patch Set #15, Line 2228: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);

    Why do you need to shutdown like this here?

    Removed it. Not needed

  • Patch Set #15, Line 2237: Identity Request IMSI (retrans)

    Likewise, the test does reply to the 2nd Identity Request.

    Done

To view, visit change 39256. To unsubscribe, or for help writing mail filters, visit settings.