Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email ) Change subject: stream: Add and use helper function osmo_ipa_push_headers() ...................................................................... Patch Set 21: Code-Review+1 (4 comments) File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/a5751a09_1d6a8e44 PS20, Line 6: #include <osmocom/netif/stream.h>
This header file contains a protocol definition, and making it contain the whole stream API does not […] Not needed anymore, marking as resolved.
File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/708b20bf_2f9d4b1a PS20, Line 443: struct msgb *msg
If we go for exposing this API (see my other comment), the `msg` pointer should become the first arg […] Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/2874863a_c1e819ea PS20, Line 456: osmo_ipa_stream_srv_send
I agree with fixeria here, I already shared my concerns about this kind of API ;) Done
File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/09e02332_e447ce50 PS14, Line 582: osmo_ipa_stream_srv_send(conn, IPAC_PROTO_IPACCESS, -1, m);
Agreeing with @pespin@sysmocom.de here. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 33201 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 14:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment