Attention is currently required from: arehbein, pespin.

Patch set 21:Code-Review +1

View Change

4 comments:

• File include/osmocom/netif/ipa.h:

  • Patch Set #20, Line 6: #include <osmocom/netif/stream.h>

    This header file contains a protocol definition, and making it contain the whole stream API does not […]

    Not needed anymore, marking as resolved.

• File src/ipa.c:

  • Patch Set #20, Line 443: struct msgb *msg

    If we go for exposing this API (see my other comment), the `msg` pointer should become the first arg […]

    Done

  • Patch Set #20, Line 456: osmo_ipa_stream_srv_send

    I agree with fixeria here, I already shared my concerns about this kind of API ;)

    Done

• File tests/stream/stream_test.c:

  • Patch Set #14, Line 582: osmo_ipa_stream_srv_send(conn, IPAC_PROTO_IPACCESS, -1, m);

    Agreeing with @pespin@sysmocom.de here.

    Done

To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.