Attention is currently required from: dexter, fixeria, lynxis lazus.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email )
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: Only a couple minor changes, once fixed +1 from me.
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/504d7254_c6ad9517?usp... : PS2, Line 379: if (params->p3t < 0 || params->p3t > 65535 || params->p3t < 2 * params->p1t) better enclose (2*params->p1t) into parenthesis? also below in line 388.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/6d7a1408_e07bc7be?usp... : PS2, Line 623: } else if (rc > 0) { no need for "} else" here (early return), remove it.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/c78d9b40_baeededa?usp... : PS2, Line 636: } else if (rc > 0) { no need for "} else" here (early return), remove it.