Attention is currently required from: dexter, fixeria, lynxis lazus.

View Change

4 comments:

• Patchset:

  • Patch Set #2:

    Only a couple minor changes, once fixed +1 from me.

• File src/sgsn/gprs_sndcp_xid.c:

  • Patch Set #2, Line 379: if (params->p3t < 0 || params->p3t > 65535 || params->p3t < 2 * params->p1t)

    better enclose (2*params->p1t) into parenthesis? also below in line 388.

  • Patch Set #2, Line 623: } else if (rc > 0) {

    no need for "} else" here (early return), remove it.

  • Patch Set #2, Line 636: } else if (rc > 0) {

    no need for "} else" here (early return), remove it.

To view, visit change 43958. To unsubscribe, or for help writing mail filters, visit settings.