Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email ) Change subject: Add VTY test for "listen" node of osmo-stp VTY config ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/0293eae1_325645... : PS2, Line 393: help : list [with-flags] : show vty-attributes : show vty-attributes (application|library|global) : write terminal : write file [PATH] : write memory : write : show running-config : exit : end see below https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/2871d5b2_5bf96b... : PS2, Line 415: help Description of the interactive help system : list Print command list : show Show running system information : write Write running configuration to memory, network, or terminal : exit Exit current mode and down to previous mode : end End current mode and change to enable mode. those commands do not originate in libosmo-sigtran, do they? If libosmocore were to change the help message of any of these, our libosmo-sigtran VTY tests woould fail. As pespin wrote: Please make sure you only test the commands libsmo-sigtran adds. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/09abc43d_190bb0... : PS2, Line 431: init-ip-dscp Specify IP DSCP of Listener like here... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6 Gerrit-Change-Number: 42817 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 08:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes