Attention is currently required from: jolly, pespin.

Patch set 2:Code-Review -1

View Change

3 comments:

• File tests/vty/osmo_stp_test.vty:

  • Patch Set #2, Line 393:

    help
      list [with-flags]
      show vty-attributes
      show vty-attributes (application|library|global)
      write terminal
      write file [PATH]
      write memory
      write
      show running-config
      exit
      end
    

    see below

  • Patch Set #2, Line 415:

     help                    Description of the interactive help system
      list                    Print command list
      show                    Show running system information
      write                   Write running configuration to memory, network, or terminal
      exit                    Exit current mode and down to previous mode
      end                     End current mode and change to enable mode.
    

    those commands do not originate in libosmo-sigtran, do they? If libosmocore were to change the help message of any of these, our libosmo-sigtran VTY tests woould fail.

    As pespin wrote: Please make sure you only test the commands libsmo-sigtran adds.

  • Patch Set #2, Line 431: init-ip-dscp Specify IP DSCP of Listener

    like here...

To view, visit change 42817. To unsubscribe, or for help writing mail filters, visit settings.