Attention is currently required from: dexter, laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 11: (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/b9eb76ed_9d0b6c51?usp=ema... : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200])
I still see % being used and no "if clause". […] I fail to understand what exactly we are now discussing here for a simple change from print to logger.debug. The json output is massive so it is reasonably truncated to the beginning because that is where something interesting might be found and what exactly is dumping full kilobytes of json supposed to accomplish? In particular with chunked, fat pp. The % style is what was originally used, i kept it that way, because I did not want to discuss why I changed it to a new fancy f-string. Yet here we are.
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 14 Aug 2025 15:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>