Attention is currently required from: dexter, laforge, lynxis lazus.

View Change

1 comment:

• File osmo-smdpp.py:

  • Patch Set #6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200])

    I still see % being used and no "if clause". […]

    I fail to understand what exactly we are now discussing here for a simple change from print to logger.debug. The json output is massive so it is reasonably truncated to the beginning because that is where something interesting might be found and what exactly is dumping full kilobytes of json supposed to accomplish? In particular with chunked, fat pp. The % style is what was originally used, i kept it that way, because I did not want to discuss why I changed it to a new fancy f-string. Yet here we are.

To view, visit change 40468. To unsubscribe, or for help writing mail filters, visit settings.