Attention is currently required from: Hoernchen, dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43727?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: verify apdu commands in scripts and -e options up front ...................................................................... pySim-shell: verify apdu commands in scripts and -e options up front Statically verify -e parameters and scripts so we don't end up with half executed command chains that leave the card in a weird state due to malformed commands. This is a structural check, and not a strict mode linter, it will not magically fix a case 4 with missing Le that looks like a valid case 3! run_script, bulk_script and the @ / @@ shortcuts are followed recursively, aliases and macros are not resolved. A script that an earlier line writes via output redirection is skipped. Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec --- M pySim-shell.py A tests/unittests/test_shell_startup_verify.py 2 files changed, 231 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/43727/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec Gerrit-Change-Number: 43727 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: Hoernchen <ewild@sysmocom.de>