Attention is currently required from: Hoernchen, dexter, laforge.

Hoernchen uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Verified-1 by Jenkins Builder

pySim-shell: verify apdu commands in scripts and -e options up front

Statically verify -e parameters and scripts so we don't end up with half
executed command chains that leave the card in a weird state due to
malformed commands. This is a structural check, and not a strict mode
linter, it will not magically fix a case 4 with missing Le that looks
like a valid case 3!

run_script, bulk_script and the @ / @@ shortcuts are followed
recursively, aliases and macros are not resolved. A script that an
earlier line writes via output redirection is skipped.

Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec
---
M pySim-shell.py
A tests/unittests/test_shell_startup_verify.py
2 files changed, 231 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/43727/2

To view, visit change 43727. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec
Gerrit-Change-Number: 43727
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>