Attention is currently required from: daniel, laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email )
Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ......................................................................
Patch Set 3:
(5 comments)
File src/ss7_as_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/d686c291_162c99... : PS3, Line 266: DEFUN_USRATTR(as_tcap_unroutable_route_fallback, as_tcap_unroutable_route_fallback_cmd,
It probably make much more sense to have a VTY cmd […]
Done
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/3493aa81_64fce1... : PS3, Line 470: if (as->cfg.loadshare.tcap.unroutable_tcap_fallback_dpc == 0)
this is imho incorrect. 0 is a valid DPC afaiu. […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/66242a19_8da0fd... : PS3, Line 474: new_mtp.opc = orig_mtp->opc;
this line is a noop, cam be dropped.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/612da7d8_44775a... : PS3, Line 487: * \return 0 on success and asp is set, < 0 on error, > 0 when message is routed elsewhere
I see you are updating the return signature here, but I see no modficiation on any code using the fu […]
the code already handles the different rc.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/e47defe6_5a5eae... : PS3, Line 508: /* Message is handled and will be routed else where */
elsewhere
Done