Attention is currently required from: daniel, laforge, pespin.

View Change

5 comments:

• File src/ss7_as_vty.c:

  • Patch Set #3, Line 266: DEFUN_USRATTR(as_tcap_unroutable_route_fallback, as_tcap_unroutable_route_fallback_cmd,

    It probably make much more sense to have a VTY cmd […]

    Done

• File src/tcap_as_loadshare.c:

  • Patch Set #3, Line 470: if (as->cfg.loadshare.tcap.unroutable_tcap_fallback_dpc == 0)

    this is imho incorrect. 0 is a valid DPC afaiu. […]

    Done

  • Patch Set #3, Line 474: new_mtp.opc = orig_mtp->opc;

    this line is a noop, cam be dropped.

    Done

  • Patch Set #3, Line 487: * \return 0 on success and asp is set, < 0 on error, > 0 when message is routed elsewhere

    I see you are updating the return signature here, but I see no modficiation on any code using the fu […]

    the code already handles the different rc.

  • Patch Set #3, Line 508: /* Message is handled and will be routed else where */

    elsewhere

    Done

To view, visit change 43008. To unsubscribe, or for help writing mail filters, visit settings.