Attention is currently required from: neels, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 )
Change subject: mgcp_codec: fix codec decision ......................................................................
Patch Set 12:
(7 comments)
Patchset:
PS11:
Somehow `tests/mgcp/mgcp_test.ok` is seen by Gerrit as a binary file? […]
This might be due to the MCGP/SDP we dump in the ok.file Maybe the line breaks at the end confuse gerrit? My editor at least does not complain. Especially in #define CRCX_ZYN we use sometimes \r and \n or both.
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/41faa488_963689ad PS11, Line 362: found_same_codec = &rtp_end->codecs[i];
just do: […]
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/c244192c_8dcacc7d PS11, Line 367: return found_same_codec;
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/6d2cf65b_ea0b9f47 PS11, Line 408: struct mgcp_rtp_codec *codec_conn_dst = NULL;
cosmetic: can be moved inside the loop bodies
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/164f53c0_c6f0dd89 PS11, Line 423: if (conn_dst->end.codecs_assigned == 0) {
In order to avoid code duplication, I would merge this block into the previous one: […]
Done
File tests/mgcp/mgcp_test.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/0814b158_3b0a68f3 PS11, Line 1808:
ws
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/6a30d4cd_484278a4 PS11, Line 1976:
ws
Done