Attention is currently required from: neels, fixeria, pespin.
7 comments:
Patchset:
Somehow `tests/mgcp/mgcp_test.ok` is seen by Gerrit as a binary file? […]
This might be due to the MCGP/SDP we dump in the ok.file Maybe the line breaks at the end confuse gerrit? My editor at least does not complain. Especially in #define CRCX_ZYN we use sometimes \r and \n or both.
File src/libosmo-mgcp/mgcp_codec.c:
Patch Set #11, Line 362: found_same_codec = &rtp_end->codecs[i];
just do: […]
Done
Patch Set #11, Line 367: return found_same_codec;
``` […]
Done
Patch Set #11, Line 408: struct mgcp_rtp_codec *codec_conn_dst = NULL;
cosmetic: can be moved inside the loop bodies
Done
Patch Set #11, Line 423: if (conn_dst->end.codecs_assigned == 0) {
In order to avoid code duplication, I would merge this block into the previous one: […]
Done
File tests/mgcp/mgcp_test.c:
ws
Done
ws
Done
To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.