Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 4: Code-Review-1 (3 comments) Patchset: PS4: CR-1 due to potential API duplication. File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/08083a0d_c033e... : PS4, Line 358: as_gmm_auth You're adding this altstep, but not using it? Is it for a follow-up patch? I see there's also `f_gmm_auth()` below, so what's the difference between the two? I may be wrong, but I smell code duplication... If your new API is supposed to replace the `f_gmm_auth()`, then the later should be removed. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/da229720_6b832... : PS4, Line 363: Ignoring autn for now TODO? `f_gmm_auth()` does handle AUTN, by the way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:17:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes