Attention is currently required from: laforge, lynxis lazus, pespin.
Patch set 4:Code-Review -1
3 comments:
Patchset:
CR-1 due to potential API duplication.
File sgsn/BSSGP_ConnHdlr.ttcn:
Patch Set #4, Line 358: as_gmm_auth
You're adding this altstep, but not using it? Is it for a follow-up patch? I see there's also `f_gmm_auth()` below, so what's the difference between the two?
I may be wrong, but I smell code duplication... If your new API is supposed to replace the `f_gmm_auth()`, then the later should be removed.
Patch Set #4, Line 363: Ignoring autn for now
TODO? `f_gmm_auth()` does handle AUTN, by the way.
To view, visit change 38396. To unsubscribe, or for help writing mail filters, visit settings.