Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: +1 once you fix the vty tests in this same commit, see also my other 2 comments regarding vty output improvements.
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/e50eadfb_7e5682... : PS4, Line 420: struct osmo_ss7_asp *asp = vty->index; btw, I'd personally add a vty_out() here telling the user this vty is deprecated and that qos-class should be used instead.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/df2fa597_55eae8... : PS4, Line 449: vty_out(vty, "%% Config updated: ip-dscp %d -> %d%s", asp->cfg.ip_dscp, qos->ip_dscp, I think you are missing the "qoss-class" somewhere in the string? like " -> qos-class %d (ip-dscp %d)"