Attention is currently required from: jolly.
3 comments:
Patchset:
+1 once you fix the vty tests in this same commit, see also my other 2 comments regarding vty output improvements.
File src/ss7_asp_vty.c:
Patch Set #4, Line 420: struct osmo_ss7_asp *asp = vty->index;
btw, I'd personally add a vty_out() here telling the user this vty is deprecated and that qos-class should be used instead.
Patch Set #4, Line 449: vty_out(vty, "%% Config updated: ip-dscp %d -> %d%s", asp->cfg.ip_dscp, qos->ip_dscp,
I think you are missing the "qoss-class" somewhere in the string? like " -> qos-class %d (ip-dscp %d)"
To view, visit change 43667. To unsubscribe, or for help writing mail filters, visit settings.