dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 ) Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ...................................................................... Patch Set 1: (2 comments) This is not fully finished yet. As suggested I will make the functions AF agnostic as well and fix the X213 NSAP problem. https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/1/src/osmo-hnbgw/ranap_rab_a... File src/osmo-hnbgw/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/1/src/osmo-hnbgw/ranap_rab_a... PS1, Line 473: int ranap_rab_ass_resp_replace_inet_addr(uint8_t *data, unsigned int data_len, const char *addr, uint32_t port)
why passing the addr here is string format? I'd make more sense to pass a osmo_sockaddr. Yes, its probably a good idea to make this functions also AF agnostic.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/1/src/osmo-hnbgw/ranap_rab_a... PS1, Line 520: temp_transport_layer_information = ranap_new_transp_info_rtp(&ip_addr, true); //<============= FIXME!
what about this? This is not ready yet. We need to determine the address encoding and retain it. This converts everything to X.213 NSAP, which is not correct.
-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837 Gerrit-Change-Number: 26792 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jan 2022 16:28:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment