This is not fully finished yet. As suggested I will make the functions AF agnostic as well and fix the X213 NSAP problem.

View Change

2 comments:

• File src/osmo-hnbgw/ranap_rab_ass.c:

  • Patch Set #1, Line 473: int ranap_rab_ass_resp_replace_inet_addr(uint8_t *data, unsigned int data_len, const char *addr, uint32_t port)

    why passing the addr here is string format? I'd make more sense to pass a osmo_sockaddr.

    Yes, its probably a good idea to make this functions also AF agnostic.

  • Patch Set #1, Line 520: temp_transport_layer_information = ranap_new_transp_info_rtp(&ip_addr, true); //<============= FIXME!

    what about this?

    This is not ready yet. We need to determine the address encoding and retain it. This converts everything to X.213 NSAP, which is not correct.

To view, visit change 26792. To unsubscribe, or for help writing mail filters, visit settings.