Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32985 )
Change subject: rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 ......................................................................
Patch Set 2:
(4 comments)
File include/osmocom/gprs/rlcmac/rlcmac_private.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/1d1c9e60_d0b1af4b PS2, Line 94: gprs_rlcmac_handle_ccch_pag_req_1 cosmetic: maybe `..._pag_req1` or `..._pag_req_type1`?
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/8fc2b204_fb3f55b7 PS2, Line 338: struct gsm48_paging1 *pag const?
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/13ad537b_d094ce39 PS2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag)) Not sure why would you want to check this at run-time. Looks like a candidate for `osmo_static_assert`?
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/4f43b092_2b79d922 PS2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1) Same here, `sizeof(*pag)` does not change at run-time, right?