Attention is currently required from: pespin.

View Change

4 comments:

• File include/osmocom/gprs/rlcmac/rlcmac_private.h:

  • Patch Set #2, Line 94: gprs_rlcmac_handle_ccch_pag_req_1

    cosmetic: maybe `..._pag_req1` or `..._pag_req_type1`?

• File src/rlcmac/rlcmac.c:

  • Patch Set #2, Line 338: struct gsm48_paging1 *pag

    const?

  • Patch Set #2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag))

    Not sure why would you want to check this at run-time.
    Looks like a candidate for `osmo_static_assert`?

  • Patch Set #2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1)

    Same here, `sizeof(*pag)` does not change at run-time, right?

To view, visit change 32985. To unsubscribe, or for help writing mail filters, visit settings.