Attention is currently required from: fixeria, lynxis lazus.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email )
Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ......................................................................
Patch Set 2:
(2 comments)
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43953/comment/373d8ed1_168d20ce?usp... : PS1, Line 596: VTVLV_GAN_GROSS_LEN
Any reason to use GAN specific macros here? Why not plain `TLV_GROSS_LEN`?
I was a bit of track here, it's of course TVLV_GROSS_LEN, we also cannot have comp_bytes results larger than 255 bytes then. The buffer size of 512 is a bit misleading here. I was assuming that we have length fields with variable length here, but we don't...
https://gerrit.osmocom.org/c/osmo-sgsn/+/43953/comment/c2028603_f46e05ad?usp... : PS1, Line 609: SNDCP_XID_DATA_COMPRESSION
Done