Attention is currently required from: fixeria, lynxis lazus.

View Change

2 comments:

• File src/sgsn/gprs_sndcp_xid.c:

  • Patch Set #1, Line 596: VTVLV_GAN_GROSS_LEN

    Any reason to use GAN specific macros here? Why not plain `TLV_GROSS_LEN`?

    I was a bit of track here, it's of course TVLV_GROSS_LEN, we also cannot
     have comp_bytes results larger than 255 bytes then. The buffer size of 
    512 is a bit misleading here. I was assuming that we have length fields 
    with variable length here, but we don't...

  • Patch Set #1, Line 609: SNDCP_XID_DATA_COMPRESSION

    ```suggestion […]

    Done

To view, visit change 43953. To unsubscribe, or for help writing mail filters, visit settings.