Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 )
Change subject: immediately SCCP RLSD on HNB re-register ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS1:
ST_DISCONNECTED means we received a RUA Disconnect message. […]
Ok, but I think you didn't mention the RUA_Disconnect message there, now it's clearer.
Patchset:
PS2: I'm fine with having the name changes in another commit.
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/e839d8ca_6451be04 PS1, Line 362: tx_sccp_df1(fi, ranap_msg); : tx_sccp_rlsd(fi);
I understand the "tx" as "send down the user SAP", not necessarily transmit on a wire. […]
I think "dispatch" or "submit" are better candidates than "transmit" or "send" when passing stuff accross layers. Even "send_down" would be better than transmit.