Attention is currently required from: neels, laforge.

Patch set 2:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    ST_DISCONNECTED means we received a RUA Disconnect message. […]

    Ok, but I think you didn't mention the RUA_Disconnect message there, now it's clearer.

• Patchset:

  • Patch Set #2:

    I'm fine with having the name changes in another commit.

• File src/osmo-hnbgw/context_map_sccp.c:

  • Patch Set #1, Line 362:

    tx_sccp_df1(fi, ranap_msg);
    		tx_sccp_rlsd(fi);
    

    I understand the "tx" as "send down the user SAP", not necessarily transmit on a wire. […]

    I think "dispatch" or "submit" are better candidates than "transmit" or "send" when passing stuff accross layers. Even "send_down" would be better than transmit.

To view, visit change 32915. To unsubscribe, or for help writing mail filters, visit settings.