Attention is currently required from: Timur Davydov. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email ) Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... Patch Set 2: (12 comments) File src/common/osmux.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/5a95b21b_7a282ef7?usp=... : PS2, Line 132: if (rc < 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/a1df2821_13eb3ff3?usp=... : PS2, Line 578: int ws_osmux_push_raw_data(const char* data, size_t sz) "foo* bar" should be "foo *bar" File src/osmo-bts-trx/osmo-bts-trx-websdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/62ebccb3_a3bb4b07?usp=... : PS2, Line 48: #endif /* OSMO_BTS_TRX_WEBSDR_H */ adding a line without newline at end of file File src/osmo-bts-trx/osmo-bts-trx-websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/803ed38f_13d6326d?usp=... : PS2, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ]; space prohibited after that open square bracket '[' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/93f53bd7_733103cf?usp=... : PS2, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ]; space prohibited before that close square bracket ']' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/338c65ac_c641a689?usp=... : PS2, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ]; space prohibited after that open square bracket '[' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/dd5061ee_b3fd249e?usp=... : PS2, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ]; space prohibited before that close square bracket ']' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/01cf9c44_4d7525b2?usp=... : PS2, Line 91: char *params[] = { char * array declaration might be better as static const Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/e7eddb14_0b9fab7a?usp=... : PS2, Line 96: const size_t num_params = sizeof(params) / sizeof(params[0]); Prefer ARRAY_SIZE(params) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/6d3cc76a_bd6f0fa1?usp=... : PS2, Line 156: if (start_fn == ~0u) { braces {} are not necessary for single statement blocks File src/osmo-bts-trx/scheduler_trx.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/522299cb_7b209ff7?usp=... : PS2, Line 789: void on_sched_timer(unsigned frames) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/d3bf333c_b509ebbd?usp=... : PS2, Line 799: #endif /* ENABLE_WEBSDR */ adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp@gmail.com> Gerrit-Comment-Date: Mon, 27 Apr 2026 00:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No