Attention is currently required from: Timur Davydov.

View Change

12 comments:

• File src/common/osmux.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 132: if (rc < 0) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 578: int ws_osmux_push_raw_data(const char* data, size_t sz)

    "foo* bar" should be "foo *bar"

• File src/osmo-bts-trx/osmo-bts-trx-websdr.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 48: #endif /* OSMO_BTS_TRX_WEBSDR_H */

    adding a line without newline at end of file

• File src/osmo-bts-trx/osmo-bts-trx-websdr.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ];

    space prohibited after that open square bracket '['

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 66: int16_t sdr_send_buffer[ MAX_BUFS * BURST_DURATION * 2 ];

    space prohibited before that close square bracket ']'

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ];

    space prohibited after that open square bracket '['

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 67: uint64_t sdr_send_bts[ MAX_BUFS ];

    space prohibited before that close square bracket ']'

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 91: char *params[] = {

    char * array declaration might be better as static const

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 96: const size_t num_params = sizeof(params) / sizeof(params[0]);

    Prefer ARRAY_SIZE(params)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 156: if (start_fn == ~0u) {

    braces {} are not necessary for single statement blocks

• File src/osmo-bts-trx/scheduler_trx.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 789: void on_sched_timer(unsigned frames) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #2, Line 799: #endif /* ENABLE_WEBSDR */

    adding a line without newline at end of file

To view, visit change 42703. To unsubscribe, or for help writing mail filters, visit settings.