Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email )
Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ......................................................................
Patch Set 2:
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43595/comment/afc22752_acce94c7?usp... : PS2, Line 1286: LOGPC(DMM, LOGL_INFO, "MI(%s) type="%s"\n", mi_log_string,
What's actually the pooint of printing with LOGPC here if we add a \n at the end?
I guess original the idea was to start the log line with "-> GMM ATTACH REQUEST " and then extend it with more and more logging as process goes. But AFAIU LOGPC should be only used if the LOG_LEVEL is the same and there is no log line in between.
So this log line is only extending it here once instead of multiple time.