Attention is currently required from: fixeria, pespin.

View Change

1 comment:

• File src/sgsn/gprs_gmm.c:

  • Patch Set #2, Line 1286: LOGPC(DMM, LOGL_INFO, "MI(%s) type=\"%s\"\n", mi_log_string,

    What's actually the pooint of printing with LOGPC here if we add a \n at the end?

    I guess original the idea was to start the log line with "-> GMM ATTACH REQUEST " and then extend it with more and more logging as process goes.
    But AFAIU LOGPC should be only used if the LOG_LEVEL is the same and there is no log line in between.

    So this log line is only extending it here once instead of multiple time.

To view, visit change 43595. To unsubscribe, or for help writing mail filters, visit settings.