Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42553?usp=email )
Change subject: filesystem: JsonEditor: use NamedTemporaryFile ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: I have tested this. I think it is very helpful that the editor now knows that it is a JSON file and therefore switches on syntax highlighting.
It all works will. However when I intentionally provoke a JSONDecodeError I can see that the file continues to exist. With the current master the temp directory vanishes. Probably there is something broken now. I think it would be good if you could check this back.
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/42553/comment/e6d71e82_c25046a8?usp=ema... : PS4, Line 606: self._file = tempfile.NamedTemporaryFile(prefix='pysim', suffix='.json', maybe continue to use 'pysim_' as prefix?
(maybe it would also make sense to encode the FID path into the filename? I don't know maybe some will find this hepful)