Attention is currently required from: fixeria.
2 comments:
Patchset:
I have tested this. I think it is very helpful that the editor now knows that it is a JSON file and therefore switches on syntax highlighting.
It all works will. However when I intentionally provoke a JSONDecodeError I can see that the file continues to exist. With the current master the temp directory vanishes. Probably there is something broken now. I think it would be good if you could check this back.
File pySim/filesystem.py:
Patch Set #4, Line 606: self._file = tempfile.NamedTemporaryFile(prefix='pysim', suffix='.json',
maybe continue to use 'pysim_' as prefix?
(maybe it would also make sense to encode the FID path into the filename? I don't know maybe some will find this hepful)
To view, visit change 42553. To unsubscribe, or for help writing mail filters, visit settings.