Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43866?usp=email ) Change subject: personalization: SUCI: ff-pad remaining file size ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43866/comment/10ddcd69_ae21cd4e?usp=ema... : PS1, Line 1340: is_size = f_sucici.file_size : pad_n = is_size - len(body) : if pad_n > 0: : body = body + b'\xff' * pad_n I'm rather certain we have implemented ff-padding a number of times in pysim and/or pyosmocom already. We have the osmocom.construct.Rpad(Adapter) for construct, we have osmocom.utils.rpad() for hex-strings, we have various padding methods in pySim.ota as well as pySim.esim.bsp. Let's please not add an hand-rolled, open-coding padding here. Either we can somehow use or generalize an existing function/method, or we introduce a new one that is used here (and potentially elswehwere) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9465eac9269e3f76dddd467109f547489a0feb93 Gerrit-Change-Number: 43866 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 08:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No