Attention is currently required from: neels.

View Change

1 comment:

• File pySim/esim/saip/personalization.py:

  • Patch Set #1, Line 1340:

                is_size = f_sucici.file_size
                pad_n = is_size - len(body)
                if pad_n > 0:
                    body = body + b'\xff' * pad_n
    

    I'm rather certain we have implemented ff-padding a number of times in pysim and/or pyosmocom already. We have the osmocom.construct.Rpad(Adapter) for construct, we have osmocom.utils.rpad() for hex-strings, we have various padding methods in pySim.ota as well as pySim.esim.bsp.

    Let's please not add an hand-rolled, open-coding padding here. Either we can somehow use or generalize an existing function/method, or we introduce a new one that is used here (and potentially elswehwere)

To view, visit change 43866. To unsubscribe, or for help writing mail filters, visit settings.