Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30963 ) Change subject: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm48_cc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30963/comment/fe4ca38b_e93e41c0 PS1, Line 54: if (cc->mncc_upqueue.next != NULL)
Using llist_empty() means doing this: […] Feel free to merge this patch if you want, but I think we really fix the code to properly initialize the cc->mncc_upqueue with INIT_LLIST or whatever, instead of doing adhoc assumptions checking against NULL, etc.
-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858 Gerrit-Change-Number: 30963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment