Attention is currently required from: neels, fixeria.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/host/layer23/src/mobile/gsm48_cc.c:

  • Patch Set #1, Line 54: if (cc->mncc_upqueue.next != NULL)

    Using llist_empty() means doing this: […]

    Feel free to merge this patch if you want, but I think we really fix the code to properly initialize the cc->mncc_upqueue with INIT_LLIST or whatever, instead of doing adhoc assumptions checking against NULL, etc.

To view, visit change 30963. To unsubscribe, or for help writing mail filters, visit settings.