Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30465 ) Change subject: clarify comments and naming around PDR+FAR classification ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File include/osmocom/upf/up_session.h: https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/8c8cbd7f_f6ab61ee PS1, Line 97: bool access_to_core; Isn't access_to_core and core_to_access exclusive? meaning it's one or another and hence can be stored in one bool? Or can both be present? File src/osmo-upf/up_session.c: https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/1e47335d_e3e7b264 PS1, Line 1140: static void add_gtp_action_tunend(void *ctx, struct llist_head *dst, struct pdr *pdr) Looks like this function should return an int? https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/ba18d7dc_c4fe3215 PS1, Line 1235: static void add_gtp_action_tunmap(void *ctx, struct llist_head *dst, struct pdr *pdr) Same, looks like this function should return an int? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia199bb6944476eff6af89b5ab015a9a2f8ce330e Gerrit-Change-Number: 30465 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 10:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment