Attention is currently required from: neels.

Patch set 1:Code-Review +1

View Change

3 comments:

• File include/osmocom/upf/up_session.h:

  • Patch Set #1, Line 97: bool access_to_core;

    Isn't access_to_core and core_to_access exclusive? meaning it's one or another and hence can be stored in one bool? Or can both be present?

• File src/osmo-upf/up_session.c:

  • Patch Set #1, Line 1140: static void add_gtp_action_tunend(void *ctx, struct llist_head *dst, struct pdr *pdr)

    Looks like this function should return an int?

  • Patch Set #1, Line 1235: static void add_gtp_action_tunmap(void *ctx, struct llist_head *dst, struct pdr *pdr)

    Same, looks like this function should return an int?

To view, visit change 30465. To unsubscribe, or for help writing mail filters, visit settings.