Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882?usp=email ) Change subject: Osmocom_CTRL_Functions.ttcn: Use Misc_Helpers.f_shutdown() everywhere ...................................................................... Patch Set 3: (1 comment) File library/Osmocom_CTRL_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882/comment/bd576aeb_e2cfd... : PS2, Line 47: log2str
What's the reason there? Because it gets in the way of searching for setverdict() in the code? I am fine with using `f_shutdown()` instead of `mtc.stop`, because this way we [hopefully] stop all PTCs and logs a very useful message with the file and line number from where the shutdown was called. But I don't see if win anything by [ab]using `f_shutdown()` for setting the verdict: you have to use `log2str()` and the message ends up further away towards the line length limit. It looks ugly and cumbersome to me that way.
I generally don't like that `f_shutdown()` is even usable to set a verdict by design. Ideally it should only do what its name suggests (following the UNIX philosophy): shutdown all the parallel components. There exists built-in API for setting a verdict - `setverdict()`, which does concatenate all arguments following after the `verdictop` into a single string automatically and does not require to use TITAN specific extensions like `log2str()`. This is my take on it. Looks like nobody else does share this view. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b11a4dee35da89b2fec0cc66021dd57db04beb4 Gerrit-Change-Number: 38882 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 19:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>